Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: authors check using OISF repo #10333

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
None but https://github.com/OISF/suricata/security/code-scanning/238

Describe changes:

  • Checks out Suricata OISF repo and not contributor repository to run git log on it

cc @jasonish

#10332 as no longer a draft (where you can see the last 2 runs of the new author check)

As flagged critical by codescan
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, tested with a PR against my own repo.

@victorjulien victorjulien added this to the 8.0 milestone Feb 9, 2024
@victorjulien
Copy link
Member

Merged in #10347, thanks!

@catenacyber
Copy link
Contributor Author

And https://github.com/OISF/suricata/security/code-scanning/238 is fixed

And we do not have anymore critical code scanning alerts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants