Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/280/20240209/v1 #10347

Merged
merged 5 commits into from
Feb 9, 2024
Merged

next/280/20240209/v1 #10347

merged 5 commits into from
Feb 9, 2024

Conversation

victorjulien
Copy link
Member

catenacyber and others added 5 commits February 9, 2024 11:24
@catenacyber @victorjulien
ci: authors check using OISF repo
7f5e98e 
As flagged critical by codescan
@catenacyber @victorjulien
rust: fix clippy ptr_arg warnings
68b0052 
error: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
   --> src/dns/log.rs:371:29
    |
371 | pub fn dns_print_addr(addr: &Vec<u8>) -> std::string::String {
    |                             ^^^^^^^^ help: change this to: `&[u8]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
@jasonish @victorjulien
detect-http: add superfluous alloc check for cocci
f800ed0 
Add not-needed SCCalloc return check to satisfy our Cocci malloc
checks as it can't see that the caller immediately checks the return
value of this simple wrapper around SCCalloc.
@catenacyber @victorjulien
detect/http_header: fix leak on realloc failure
b48ec8a
@victorjulien
detect/http: report error on alloc failure
7e4dba7
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (80abc22) 82.32% compared to head (7e4dba7) 82.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10347      +/-   ##
==========================================
- Coverage   82.32%   82.32%   -0.01%     
==========================================
  Files         978      978              
  Lines      272142   272147       +5     
==========================================
- Hits       224053   224040      -13     
- Misses      48089    48107      +18
Flag Coverage Δ
fuzzcorpus 63.59% <53.84%> (-0.01%) ⬇️
suricata-verify 61.45% <53.84%> (-0.04%) ⬇️
unittests 62.83% <15.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

inashivb
inashivb approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorjulien victorjulien merged commit 7e4dba7 into OISF:master Feb 9, 2024
45 checks passed
This was referenced Feb 9, 2024
Closed
Closed
@victorjulien victorjulien deleted the next/280/20240209/v1 branch February 9, 2024 13:31
@inashivb inashivb mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @inashivb @catenacyber @jasonish