Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: improve CPU cores affinity to NUMA nodes #11521

Closed

Conversation

lukashino
Copy link
Contributor

Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7036

This is a draft to discuss the user and implementation details of the ticket.

Proposal for modes of assignment:

    // threading.cpu-assignment:
    //   - legacy - assign as usual
    //   - auto - use hwloc to determine NUMA locality of the NIC and try to assign a core from this NUMA node.
    //            If it fails then use the other NUMA node.
    //            Using this approach e.g. on bonded devices/aliased and any other will not work
    //            Warn/Notify a user when device's NUMA node cannot be determined.
    //            Mention in the docs that NUMA locatity supports PCIe addresses and Kernel interfaces
    //   - manual - in workers CPU set either:
    //              - Specify in one line ([ "eth0@1,2,3,4,7-9", "eth1@10,11" ])
    //              - Specify threading in a list:
    //              - worker-cpu-set:
    //                - interface: eth0
    //                    cpu: [ 1,2,3,4 ]
    //                    mode: "exclusive" 
    //                    prio:
    //                      high: [ 3 ]
    //                      default: "medium" 

The current code draft works in somewhat auto mode - it tries to pick CPU core from the NUMA node from where the interface is.

Added doc update label to not trigger QA.

@lukashino lukashino added the typo/doc update No code change : only doc or typo fixes label Jul 18, 2024
@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_fetch.

Pipeline 21615

@lukashino lukashino removed the typo/doc update No code change : only doc or typo fixes label Jul 18, 2024
@ct0br0 ct0br0 added needs rebase Needs rebase to master and removed needs rebase Needs rebase to master labels Jul 18, 2024
@ct0br0
Copy link

ct0br0 commented Jul 18, 2024

Was too slow with the label to block QA. Will just leave it if it fails again.

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_fetch.

Pipeline 21617

@lukashino
Copy link
Contributor Author

Continue in #11706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
Development

Successfully merging this pull request may close these issues.

4 participants