Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nimbus version as an environment variable #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Nimbus version as an environment variable #116

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0b09d4
Add Nimbus version as an environment variable
EridianAlpha Mar 23, 2023
7390d74
Add latest version as fallback
EridianAlpha Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,14 @@
# Teku beacon node host exposed ports
#TEKU_PORT_METRICS=

######### Nimbus Config #########

# Nimbus validator client version, e.g. `v23.3.2`.
# See available tags https://github.com/status-im/nimbus-eth2/releases
#NIMBUS_VERSION=

######### Prysm Config #########

#PRYSM_EXECUTION_ENDPOINT=
#PRYSM_VERSION=
#PRYSM_PORT_P2P_TCP=
Expand Down
10 changes: 8 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ services:
- ./teku:/opt/charon/teku

vc2-nimbus:
build: nimbus
build:
context: ./nimbus
args:
NIMBUS_VERSION: ${NIMBUS_VERSION:-v23.3.2}
networks: [ cluster ]
depends_on: [ node2 ]
restart: unless-stopped
Expand Down Expand Up @@ -230,7 +233,10 @@ services:
- ./teku:/opt/charon/teku

vc5-nimbus:
build: nimbus
build:
context: ./nimbus
args:
NIMBUS_VERSION: ${NIMBUS_VERSION:-v23.3.2}
networks: [ cluster ]
depends_on: [ node5 ]
restart: unless-stopped
Expand Down
6 changes: 4 additions & 2 deletions nimbus/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
FROM statusim/nimbus-eth2:multiarch-v23.3.1 as nimbusbn
ARG NIMBUS_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should/can this have a default in case it ends up unset in future?

Copy link
Author

@EridianAlpha EridianAlpha Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this can have a default set, and it will be overwritten with anything that's passed through. Does this add to a maintenance overhead/ cause duplication though, as a default value is already being set in the docker-compose.yml file on line 199?

Or is this for when a user builds Nimbus directly on the CLI and forgets to pass in this argument?


FROM statusim/nimbus-validator-client:multiarch-v23.3.1
FROM statusim/nimbus-eth2:multiarch-$NIMBUS_VERSION as nimbusbn

FROM statusim/nimbus-validator-client:multiarch-$NIMBUS_VERSION

COPY --from=nimbusbn /home/user/nimbus_beacon_node /home/user/nimbus_beacon_node

Expand Down