Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Improvements #40

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Build Improvements #40

merged 6 commits into from
Nov 14, 2024

Conversation

alexlovelltroy
Copy link
Member

  • Simpler multiarch builds
  • use AMD64 v4 rather than v1
  • Add packages, rpm, deb, apk
  • Simplify Dockerfile
  • Improve clarity of Github actions

alexlovelltroy and others added 2 commits October 29, 2024 12:04
@alexlovelltroy
Build Improvements
d46dd66 
* Simpler multiarch builds
* use AMD64 v4 rather than v1
* Add packages, rpm, deb, apk
* Simplify Dockerfile
* Improve clarity of Github actions
@alexlovelltroy
Merge branch 'main' into alexlovelltroy/multiarch-containers
355a904
@alexlovelltroy alexlovelltroy mentioned this pull request Oct 30, 2024
Closed
njones-lanl
njones-lanl reviewed Nov 6, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
synackd
synackd requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment, this builds fine. But before we merge, we'll want to correct the --skip-publish to --skip publish in the goreleaser command in the README.

.goreleaser.yaml Outdated Show resolved Hide resolved
@alexlovelltroy
Copy link
Member Author

All requested changes have been made. I believe this is ready for merge. @synackd ?

synackd
synackd approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good to me and am able to build/run the container (tested on amd64).

@alexlovelltroy alexlovelltroy merged commit 7ed6c3f into main Nov 14, 2024
1 check passed
@synackd synackd deleted the alexlovelltroy/multiarch-containers branch November 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njones-lanl njones-lanl njones-lanl left review comments

@synackd synackd synackd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlovelltroy @synackd @njones-lanl