fix: Fix invalid usage of import.meta.dirname Update run.js #5370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code incorrectly uses
import.meta.dirname
to resolve the path tospecs.json
. However,import.meta.dirname
does not exist in Node.js, leading to the error:This update replaces the invalid
import.meta.dirname
usage with the correct approach, combiningpath.dirname
andimport.meta.url
. The updated logic ensures compatibility with Node.js and properly resolves the directory path.Changes made
default
value for thespec
option to:Why this change is necessary
The previous implementation would fail in environments using native ES modules in Node.js. The corrected approach leverages
import.meta.url
, which is the proper method to determine the current file's location, and ensures that the directory resolution is handled accurately.Testing
Tested the updated logic to confirm the path to
specs.json
resolves correctly in both standard Node.js environments and those using ES module syntax.PR Checklist
npx changeset add
)