-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add, get, assign, delete tags on ANY taggable resource type #163
Conversation
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
=====================================
Coverage 6.22% 6.22%
=====================================
Files 5 5
Lines 257 257
=====================================
Hits 16 16
Misses 241 241 |
85e444f
to
5ede4a0
Compare
db07ba5
to
b8eb29a
Compare
b8eb29a
to
86bdccf
Compare
63af09c
to
4f092aa
Compare
deleteCmd.AddCommand(deleteTagCmd) | ||
} | ||
|
||
func validateResourceTypeArg() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW @davidbloss and @taimoor-at-opslevel - we can write tests in the CLI codebase that test these utility functions if we want to help ensure their functionality stays the same if we ever refactor.
The problem with testing the CLI is that things like deleteTagCmd
are not testable with they way they are written.
7fccf5c
to
e40a684
Compare
@davidbloss and @rocktavious requesting re-review since tophatting:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: David Bloss <[email protected]>
Co-authored-by: David Bloss <[email protected]>
Co-authored-by: Kyle <[email protected]>
6541115
to
fb7188a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on
OpsLevel/opslevel-go#248
^Updated tag structs
Issues
https://github.com/OpsLevel/team-platform/issues/47
https://github.com/OpsLevel/team-platform/issues/44
Changelog
create
andcreate --assign
tagsdelete $TAG_ID
opslevel object get ID/ALIAS
and see the tags from there. The API does not support filtering on tags.slices
library forContains()
get tag
on any objectTophatting
This works on any taggable resource, I used a Service in this example.
Create
Update
Delete