Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better tag structs and rip out RepositoryTagConnection #248

Merged
6 commits merged into from
Sep 15, 2023
Merged

Better tag structs and rip out RepositoryTagConnection #248

6 commits merged into from
Sep 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2023 •
edited by ghost
Loading

@ghost ghost self-assigned this Sep 13, 2023
@ghost ghost mentioned this pull request Sep 13, 2023
Merged
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Merging #248 (2c1d2b4) into main (f0428d0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   79.33%   79.33%           
=======================================
  Files          50       50           
  Lines        3198     3198           
=======================================
  Hits         2537     2537           
  Misses        469      469           
  Partials      192      192
Files Changed Coverage Δ
tags.go 70.78% <ø> (ø)
repository.go 72.82% <100.00%> (ø)

@ghost ghost requested review from rocktavious and davidbloss September 13, 2023 21:38
davidbloss
davidbloss approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
I verified this with TestMarshalID

@ghost ghost marked this pull request as draft September 14, 2023 19:06
@ghost ghost marked this pull request as ready for review September 14, 2023 22:05
@ghost ghost requested review from rocktavious and davidbloss September 14, 2023 22:06
@ghost
Copy link
Author

ghost commented Sep 14, 2023

@rocktavious and @davidbloss requesting re-review here since I added a change to deprecate RepositoryTagConnection. There is no mention of this type in the terraform provider.

@ghost ghost changed the title Better tag structs Better tag structs and rip out RepositoryTagConnection Sep 14, 2023
rocktavious
rocktavious approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - as long as the tests still pass this should be good to go.

davidbloss
davidbloss approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ghost ghost merged commit c305d10 into main Sep 15, 2023
5 checks passed
@ghost ghost deleted the ta/tagstruct branch September 15, 2023 18:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocktavious @davidbloss