Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate over const structures #1448

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Iterate over const structures #1448

merged 5 commits into from
Mar 12, 2024

Conversation

DanRStevens
Copy link
Member

@DanRStevens DanRStevens commented Mar 12, 2024 •
edited
Loading

Mark Structure iterator variables explicitly as pointers (using auto* instead of auto), and apply const where possible.

Part of:

Related to:

@DanRStevens
Use auto* when iterating over planets
9a90696
@DanRStevens
Use auto* instead of auto to iterate over structures
0625f4c 
We must be explicit about the pointer if we want to allow `const` to apply to the underlying `Structure` type.
@DanRStevens
Add const when iterating over structures
349a787
@DanRStevens
Rename fp to foodProducer
ab37415
@DanRStevens
Pass vector by const& in fillOverlay
1de1f75 
Avoid having to copy potentially large vectors.
@DanRStevens DanRStevens merged commit 1ce26de into main Mar 12, 2024
7 checks passed
@DanRStevens DanRStevens deleted the constStructures branch March 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanRStevens