Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over const structures #1448

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Iterate over const structures #1448

merged 5 commits into from
Mar 12, 2024

Commits on Mar 12, 2024

  1. Use auto* when iterating over planets

    @DanRStevens
    DanRStevens committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9a90696 View commit details
    Browse the repository at this point in the history

  2. Use auto* instead of auto to iterate over structures 

    We must be explicit about the pointer if we want to allow `const` to apply to the underlying `Structure` type.
    @DanRStevens
    DanRStevens committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0625f4c View commit details
    Browse the repository at this point in the history

  3. Add const when iterating over structures

    @DanRStevens
    DanRStevens committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    349a787 View commit details
    Browse the repository at this point in the history

  4. Rename fp to foodProducer

    @DanRStevens
    DanRStevens committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ab37415 View commit details
    Browse the repository at this point in the history

  5. Pass vector by const& in fillOverlay 

    Avoid having to copy potentially large vectors.
    @DanRStevens
    DanRStevens committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1de1f75 View commit details
    Browse the repository at this point in the history