Vif: Rename some files and get rid of some asserts so the games are playable/don't crash #12028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightningterror
changed the title
The conditions need hardware testing. Use logs instead so the games don't crash and are still playable.
lightningterror
force-pushed
the
vif_asserts_file_renames
branch
from
fdb9592 to
58c84ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Vif: Rename/remove new prefix from files.
Vif: Replace some asserts with logs.
The conditions need hardware testing.
Use logs instead so the games are still playable.
Rationale behind Changes
Asserts are annoying, let the games be playable.
Fixes #8197
Fixes #9785
Suggested Testing Steps
Test #8197
Test #9785