ChdFileReader: Use core_file instead of modifing chd_open_file #12075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CDVD
Dependencies
TheLastRar
force-pushed
the
chd-core
branch
4 times, most recently
from
7899ed8 to
a5c2a0d
Compare
JordanTheToaster
approved these changes
Dec 16, 2024
kamfretoz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes the patches applied to chd_open_file, and instead uses libchdr's virtual IO API to achieve the same behaviour
Rationale behind Changes
Such patches can be missed when updating dependencies, potentially leading to difficulty updating or introduction of bugs
Additionally, this patch did not check for
CHD_OPEN_TRANSFER_FILEbefore taking ownership, this issue, however, didn't actually impact us as we always wanted that anyway.This could in future allow use to implement precaching ourselves, rather then relying on the (patched) implementation provided by libchdr.
Suggested Testing Steps
Test using CHD files