Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these two issues testing attackgoat/screen-13#68, however I'm not sure they are done in the best way yet.
Commit
e8c5d00
Fixes a panic at
spirq/src/reflect.rs:621
.Valid SPIR-V may list function body instructions after their first call. The function type declaration of course always happens before the first call. This can be reproduced with the following shader using
shader-reflect
:Commit
7ee6d99
Specialization constants that are found via
ReflectConfig::specialize(..)
areConstantValue::Typeless(_)
and remain untyped after processing their spec-const instructions. The typeless state is helpful because Vulkan doesn't require that information from users and so it is very handy to letspirq
reflect that info automatically.