Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from spirq 0.6.2 to 1.0.0 #68

Merged
merged 7 commits into from
Dec 24, 2023

Conversation

PENGUINLIONG
Copy link
Contributor

@PENGUINLIONG PENGUINLIONG commented Dec 15, 2023

Your current code won't compile because spirq>=0.6.2 is too relaxed btw

attackgoat added a commit that referenced this pull request Dec 16, 2023
Copy link
Owner

@attackgoat attackgoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for sending the update and congratulations on v1.0! 🎉

spirq has the most accurate SPIR-V data in the Rust ecosystem and is essential to this library.

Cargo.toml Outdated Show resolved Hide resolved
src/driver/shader.rs Outdated Show resolved Hide resolved
@attackgoat
Copy link
Owner

This fixes the issues with the examples in this repository, but I found a separate issue when testing a different project: GL_EXT_shader_explicit_arithmetic_types is no longer supported properly.

I will send another PR the fixes are straightforward.

@attackgoat attackgoat self-requested a review December 24, 2023 16:34
@attackgoat attackgoat merged commit 704760b into attackgoat:master Dec 24, 2023
3 checks passed
@PENGUINLIONG PENGUINLIONG deleted the update-spriq branch December 25, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants