Cleaner conditions #2338
Merged
Cleaner conditions #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauroservienti
merged commit 84dc100
into
verify-message-id-bug-with-headers
3 checks passed
SzymonPobiega
added a commit
that referenced
this pull request
Nov 7, 2023
Extract the message extraction logic with absolute minimum changes Rewrite tests Extract the messageId override extraction to a separate method ExtractMessageId Attempt to prevent message ID from headers to be overwritten by native message ID Fix tests Cleaner conditions (#2338)
mauroservienti
added a commit
that referenced
this pull request
Nov 8, 2023
Extract the message extraction logic with absolute minimum changes Rewrite tests Extract the messageId override extraction to a separate method ExtractMessageId Attempt to prevent message ID from headers to be overwritten by native message ID Fix tests Cleaner conditions (#2338) Co-authored-by: Szymon Pobiega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the conditions aspect of the message extraction tests to make the tests easier to read