v4.0 updates #26
Merged
v4.0 updates #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed from core MoveIt Pro so we'll need to include it as a submodule here now.
pac48
reviewed
Feb 16, 2024
| @@ -54,6 +60,38 @@ joint_trajectory_controller: | |||
| joint_7: | |||
| goal: 0.05 | |||
|
|
|||
| streaming_controller: | |||
There was a problem hiding this comment.
I think this needs to be named servo_controller
There was a problem hiding this comment.
servo_controller exists already, which I think it's how it should be called now, right?
So I think we can remove the streaming_controller, can't we? It's not even referenced in the configs in this package.
I removed it and things seem to still work in hardware.
There was a problem hiding this comment.
Okay, I didn't see it because I was looking at the diff. I think streaming_controller should be deleted
Co-authored-by: Paul Gesel <[email protected]>
pac48
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch
v4.0into main.Tested in mock and all seems to work, except for a tool offset I'm seeing in Servo, which I think is an issue in main:
https://github.com/PickNikRobotics/moveit_studio/issues/6498