Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support display private key discreetly #10018

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Nov 28, 2023

Motivation

close #10016

When we run leo account new or leo account import, will display private key discreently on an alternate screen. See following pics

2023-11-28_16-50-53

image

@ghost
Copy link

ghost commented Nov 28, 2023

This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.

@ghost ghost closed this Nov 28, 2023
@Halimao
Copy link
Contributor Author

Halimao commented Nov 28, 2023

This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.

This doesn't for the contributor badge, but add a new feature to leo.

@d0cd d0cd reopened this Nov 29, 2023
@Halimao
Copy link
Contributor Author

Halimao commented Nov 29, 2023

@d0cd Sincerely thanks😀

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6126189) 79.53% compared to head (f354221) 76.28%.
Report is 221 commits behind head on testnet3.

Files Patch % Lines
leo/cli/commands/account.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           testnet3   #10018      +/-   ##
============================================
- Coverage     79.53%   76.28%   -3.26%     
============================================
  Files           172      200      +28     
  Lines          5776     6759     +983     
  Branches       5776     6759     +983     
============================================
+ Hits           4594     5156     +562     
- Misses         1182     1603     +421     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Halimao
Copy link
Contributor Author

Halimao commented Jan 9, 2024

@d0cd Hi sir, can we get this merged, IMO this pr won't affect the current flow of leo account new|import, there is a new flag --discreet to use the feature of this pr

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor nits but looks good overall!
Thank you for contributing! 🚀

leo/cli/commands/account.rs Outdated Show resolved Hide resolved
leo/cli/commands/account.rs Outdated Show resolved Hide resolved
leo/cli/commands/account.rs Outdated Show resolved Hide resolved
@d0cd d0cd merged commit 195df65 into ProvableHQ:testnet3 Jan 16, 2024
13 of 15 checks passed
@Halimao Halimao deleted the feat/discreetly branch January 17, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]Support display private key discreently
2 participants