-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support display private key discreetly #10018
Conversation
This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof. |
This doesn't for the contributor badge, but add a new feature to leo. |
@d0cd Sincerely thanks😀 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## testnet3 #10018 +/- ##
============================================
- Coverage 79.53% 76.28% -3.26%
============================================
Files 172 200 +28
Lines 5776 6759 +983
Branches 5776 6759 +983
============================================
+ Hits 4594 5156 +562
- Misses 1182 1603 +421 ☔ View full report in Codecov by Sentry. |
@d0cd Hi sir, can we get this merged, IMO this pr won't affect the current flow of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor nits but looks good overall!
Thank you for contributing! 🚀
Signed-off-by: d0cd <[email protected]>
Signed-off-by: d0cd <[email protected]>
Signed-off-by: d0cd <[email protected]>
Motivation
close #10016
When we run
leo account new
orleo account import
, will display private key discreently on an alternate screen. See following pics