Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Old fork was staging #10

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Old fork was staging #10

wants to merge 24 commits into from

Commits on Mar 2, 2018

  1. Upgrade puppeteer and ws libraries 

    fixes alvarcarto#57

Reason: Chrome 63+ does closes socket without waiting for close frame
from server. Upstream WS library then throws on server. Puppeteer was
upgraded to handle this in the following commits

- puppeteer/puppeteer@80078d9
- puppeteer/puppeteer@fc2a104

Trace of this problem can be found by following these links:

- alvarcarto#57
- websockets/ws#1256
- https://bugs.chromium.org/p/chromium/issues/detail?id=798194#c6
    @eriktrom
    eriktrom committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    2a2073f View commit details
    Browse the repository at this point in the history

  2. update per assertion error: page.goto param: opts.waitUntil: 'network… 

    …Idle' -> networkIdle2
    @eriktrom
    eriktrom committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    4c7f47d View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2018

  1. Upgrade puppeteer and ws libraries 

    fixes alvarcarto#57

Reason: Chrome 63+ does closes socket without waiting for close frame
from server. Upstream WS library then throws on server. Puppeteer was
upgraded to handle this in the following commits

- puppeteer/puppeteer@80078d9
- puppeteer/puppeteer@fc2a104

Trace of this problem can be found by following these links:

- alvarcarto#57
- websockets/ws#1256
- https://bugs.chromium.org/p/chromium/issues/detail?id=798194#c6

Signed-off-by: Justin Culbertson <[email protected]>
    @eriktrom @jjculber
    eriktrom authored and jjculber committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    ffd052d View commit details
    Browse the repository at this point in the history

  2. update per assertion error: page.goto param: opts.waitUntil: 'network… 

    …Idle' -> networkIdle2

Signed-off-by: Justin Culbertson <[email protected]>
    @eriktrom @jjculber
    eriktrom authored and jjculber committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    1c0d07b View commit details
    Browse the repository at this point in the history

  3. bump ws within puppeteer

    @eriktrom
    eriktrom committed Mar 3, 2018
    Configuration menu
    Copy the full SHA
    68c8577 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. remove ws module, puppeteer brings it own

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    18ad3d7 View commit details
    Browse the repository at this point in the history

  2. use networkIdle0, timeout: 5000

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    efc109a View commit details
    Browse the repository at this point in the history

  3. if url.length > 1024, slice it at 300 chars when logging

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8bbffb8 View commit details
    Browse the repository at this point in the history

  4. limit pdf to 10mb

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    e27c2d2 View commit details
    Browse the repository at this point in the history

  5. suppress long string within error logger

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    8d1174d View commit details
    Browse the repository at this point in the history

  6. bump timeout to 2 minutes

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    b55e7f0 View commit details
    Browse the repository at this point in the history

  7. better settings try

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    29ae5de View commit details
    Browse the repository at this point in the history

  8. html: false

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    6408c3c View commit details
    Browse the repository at this point in the history

  9. fix please

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    2001030 View commit details
    Browse the repository at this point in the history

  10. format: letter; scrollPage: false;

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    e1b8216 View commit details
    Browse the repository at this point in the history

  11. scroll page automatically

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    ca2ca25 View commit details
    Browse the repository at this point in the history

  12. deepSuppressLongString for req.body

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    95ca4cc View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'eriktrom/upgrade-puppeteer' into upgrad… 

    …e_puppeteer_with_ws_fix

Conflicts:
	package.json
	src/core/pdf-core.js
	yarn.lock
    @jjculber
    jjculber committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    bbec511 View commit details
    Browse the repository at this point in the history

  14. ALLOW_HTTP=true (override all security hack, for now)

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    56c1986 View commit details
    Browse the repository at this point in the history

  15. ignore non ssl script/css links

    @eriktrom
    eriktrom committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    50f706a View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'eriktrom/upgrade-puppeteer' into upgrad… 

    …e_puppeteer_with_ws_fix
    @jjculber
    jjculber committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    3323316 View commit details
    Browse the repository at this point in the history

  17. Merge pull request #3 from RepairShopr/upgrade_puppeteer_with_ws_fix 

    Upgrade puppeteer with ws fix
    @jjculber
    jjculber authored Mar 5, 2018
    Configuration menu
    Copy the full SHA
    62f7aa7 View commit details
    Browse the repository at this point in the history

  18. Updated Yarn lockfile

    @jjculber
    jjculber committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    c4455ec View commit details
    Browse the repository at this point in the history

  19. Merge branch 'upgrade_puppeteer_with_ws_fix'

    @jjculber
    jjculber committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    361e1c3 View commit details
    Browse the repository at this point in the history