This repository has been archived by the owner on May 5, 2023. It is now read-only.
Old fork was staging #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes alvarcarto#57 Reason: Chrome 63+ does closes socket without waiting for close frame from server. Upstream WS library then throws on server. Puppeteer was upgraded to handle this in the following commits - puppeteer/puppeteer@80078d9 - puppeteer/puppeteer@fc2a104 Trace of this problem can be found by following these links: - alvarcarto#57 - websockets/ws#1256 - https://bugs.chromium.org/p/chromium/issues/detail?id=798194#c6
…Idle' -> networkIdle2
fixes alvarcarto#57 Reason: Chrome 63+ does closes socket without waiting for close frame from server. Upstream WS library then throws on server. Puppeteer was upgraded to handle this in the following commits - puppeteer/puppeteer@80078d9 - puppeteer/puppeteer@fc2a104 Trace of this problem can be found by following these links: - alvarcarto#57 - websockets/ws#1256 - https://bugs.chromium.org/p/chromium/issues/detail?id=798194#c6 Signed-off-by: Justin Culbertson <[email protected]>
…Idle' -> networkIdle2 Signed-off-by: Justin Culbertson <[email protected]>
…e_puppeteer_with_ws_fix Conflicts: package.json src/core/pdf-core.js yarn.lock
…e_puppeteer_with_ws_fix
Upgrade puppeteer with ws fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this Pull Request to highlight changes that were on RepairShopr/master, before that branch was reset and pulled upstream alvarcarto/master