Clarify help text on trip assignment creation #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan10s
approved these changes
Dec 14, 2024
| @@ -0,0 +1 @@ | |||
| Only members that have recently paid dues are shown here by default. If you need to create an assignment for a member that hasn't paid dues, go to their user details page and click <strong>Create Trip Assignment</strong> there. | |||
There was a problem hiding this comment.
maybe remove "by default" for brevity?
also is "recently paid dues" simplifying some complicated logic? is it anyone considered active (vs. access active but not active? I just feel like the wording could be more precise
There was a problem hiding this comment.
It is just access active, yes, but I don't think that's helpful information for non-technical users.
| @@ -1 +1 @@ | |||
| Only upcoming trips are shown here by default. If you need to create an assignment for a past trip, go to the trip details page and click <strong>Create Trip Assignment</strong> there. | |||
| Only upcoming trips in draft status are shown here by default. If you need to create an assignment for a past trip, go to the trip details page and click <strong>Create Trip Assignment</strong> there. | |||
There was a problem hiding this comment.
same here re "by default" unless I'm missing something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://apiary-sandbox.robojackets.org/nova/resources/trip-assignments/new