Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify help text on trip assignment creation #4968

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Clarify help text on trip assignment creation #4968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/Nova/TravelAssignment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ public function fields(NovaRequest $request): array
->withoutTrashed()
->searchable()
->rules('required', 'unique:travel_assignments,user_id,NULL,id,travel_id,'.$request->travel)
->readonly(static fn (NovaRequest $request): bool => $request->editMode === 'update'),
->readonly(static fn (NovaRequest $request): bool => $request->editMode === 'update')
->help(view('nova.help.travel.assignment.member')->render()),

BelongsTo::make('Trip', 'travel', Travel::class)
->withoutTrashed()
Expand Down
1 change: 1 addition & 0 deletions resources/views/nova/help/travel/assignment/member.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Only members that have recently paid dues are shown here by default. If you need to create an assignment for a member that hasn't paid dues, go to their user details page and click <strong>Create Trip Assignment</strong> there.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove "by default" for brevity?

also is "recently paid dues" simplifying some complicated logic? is it anyone considered active (vs. access active but not active? I just feel like the wording could be more precise

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just access active, yes, but I don't think that's helpful information for non-technical users.

2 changes: 1 addition & 1 deletion resources/views/nova/help/travel/assignment/trip.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Only upcoming trips are shown here by default. If you need to create an assignment for a past trip, go to the trip details page and click <strong>Create Trip Assignment</strong> there.
Only upcoming trips in draft status are shown here by default. If you need to create an assignment for a past trip, go to the trip details page and click <strong>Create Trip Assignment</strong> there.
Loading