OpenAI Streaming #25
Merged
OpenAI Streaming #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Aug 21, 2024
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClient.java
Show resolved
Hide resolved
newtork
reviewed
Aug 21, 2024
...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiStreamingHandler.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
e2e-test-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
...i/src/main/java/com/sap/ai/sdk/foundationmodels/openai/model/OpenAiChatCompletionOutput.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
...i/src/main/java/com/sap/ai/sdk/foundationmodels/openai/model/OpenAiChatCompletionStream.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClient.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
...odels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientException.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
...odels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientException.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Aug 22, 2024
...odels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiResponseHandler.java
Outdated
Show resolved
Hide resolved
MatKuhr
reviewed
Aug 22, 2024
e2e-test-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Show resolved
Hide resolved
newtork
reviewed
Sep 3, 2024
e2e-test-app/src/main/java/com/sap/ai/sdk/app/controllers/OpenAiController.java
Show resolved
Hide resolved
newtork
reviewed
Sep 3, 2024
| .peek(totalOutput::addDelta) | ||
| .forEach(delta -> send(emitter, delta.getDeltaContent())); | ||
| } finally { | ||
| send(emitter, "\n\n-----Total Output-----\n\n" + objectToJson(totalOutput)); |
There was a problem hiding this comment.
(Comment/Minor)
It could be worthwhile to not just dump the object-to-string. But instead to extract the relevant information and write it piece-by-piece. That would also demonstrate the actual benefit of the feature. Right now the interested reader would wonder.. "what does total output even mean? what does it contain?"
There was a problem hiding this comment.
There are potentially 30 relevant informations. Which one in particular?
Also you could say the regular OpenAiClient.chatCompletion() is confusing because it returns the total output.
Maybe you have a name suggestion for this var?
newtork
reviewed
Sep 3, 2024
...odels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiResponseHandler.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Sep 3, 2024
...ion-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientTest.java
Outdated
Show resolved
Hide resolved
* Reduce sample code * Format
newtork
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#59
Streaming allows the user to get an initial response from the LLM without waiting for the whole response.
Feature scope:
streamChatCompletion()to theOpenAiClientDefinition of Done
Release notes updated