Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI Streaming #25
OpenAI Streaming #25
Changes from all commits
d319aa9
69ae7eb
7870e6d
652ec1e
727b3d4
b3190a5
f0fa3e6
09ca6ea
d86243a
2a4ce7b
cf6ec46
a73f037
eb3f24a
fb2cdaf
fe078c7
09e1be0
42ae946
e6e009a
bee8fdc
5f03c6f
e79ca8e
ba2c5e0
c10eecb
cdae1c6
faa3b70
0e1a167
31dbd52
de7e7f0
349936f
58b0bc9
3366c2e
c709d31
73031d1
6b1bfd0
23474ba
769cd7d
118dc69
acd21c0
28268b2
9a9a44b
788db03
0616f55
3446bf0
45a20c6
f843061
5edcf71
7474fb1
ac6f36c
ffa369a
6cfeee9
6d4fd2f
a6c566a
f6a4fe6
05dedf9
2604969
9a3bf2f
a0ae779
2c934f7
77eb464
488f060
5e4ff73
59e1382
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Comment/Minor)
It could be worthwhile to not just dump the object-to-string. But instead to extract the relevant information and write it piece-by-piece. That would also demonstrate the actual benefit of the feature. Right now the interested reader would wonder.. "what does total output even mean? what does it contain?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are potentially 30 relevant informations. Which one in particular?
Also you could say the regular
OpenAiClient.chatCompletion()
is confusing because it returns the total output.Maybe you have a name suggestion for this var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor) Let's try also setting
stream_options
and assert on the token usage in the totalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not in the azure spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But as far as I can tell from my testing: it works anyway 😉
maybe they just haven't updated it yet