Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy valid images past their deprecation time #172

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Deploy valid images past their deprecation time #172

merged 1 commit into from
Aug 30, 2023

Conversation

lilyeyes
Copy link
Contributor

@lilyeyes lilyeyes commented Aug 24, 2023 •
edited
Loading

Deploy valid images past their deprecation time.

Related ticket:
TEAM-8177 - [AWS][Terraform] qe-sap-deployment cannot deploy valid images past their DeprecationTime

VRs (all as expected):

  1. VRs of 15sp3:
    1.1 VRs of "mr_test" using os_image = "suse-sles-sap-15-sp3-byos-*":
    1.1.1 Inactive image
    https://openqaworker15.qa.suse.cz/tests/217667 (passed on qesap_terraform)
    1.1.2 Deprecated image
    https://openqaworker15.qa.suse.cz/tests/217946 (passed on qesap_terraform)
    1.1.3 Deprecated image
    https://openqaworker15.qa.suse.cz/tests/217947#step/qesap_terraform/142 (passed on qesap_terraform)
    1.2 VRs of "SAPHanaSR-ScaleUp-PerfOpt" using os_image = "ami-*" accordingly:
    1.2.1 https://openqaworker15.qa.suse.cz/tests/217668 (passed on qesap_terraform)
    1.2.2 https://openqaworker15.qa.suse.cz/tests/217945 (passed on qesap_terraform)
    1.2.3 https://openqaworker15.qa.suse.cz/tests/217950# (passed on qesap_terraform)
  2. VRs of 15sp2 (by default Settings, inactive images, all passed on qesap_terraform):
    https://openqaworker15.qa.suse.cz/tests/217954
    https://openqaworker15.qa.suse.cz/tests/217955
  3. VRs of 15sp1 (by default Settings, inactive images, all passed on qesap_terraform):
    https://openqaworker15.qa.suse.cz/tests/217960
    https://openqaworker15.qa.suse.cz/tests/217961

FYI, the 15sp3 images info used in the test VRs:
[
$ aws ec2 describe-images --region eu-central-1 --filters '[{"Name": "state", "Values": ["available"]}, {"Name": "name", "Values": ["suse-sles-sap-15-sp3-byos-"]}, {"Name": "image-id", "Values": [""]}]' --include-deprecated --owners aws-marketplac
e | grep -E -i "imageid|location|depre|state"

"ImageId": "ami-0331c808bb33c6595",  
"ImageLocation": "aws-marketplace/suse-sles-sap-15-sp3-byos-v20220418-hvm-ssd-x86_64-*",   
"State": "available",  
"DeprecationTime": "2022-09-30T08:40:00.000Z"  

"ImageId": "ami-00cc4c1ada575a1d0",  
"ImageLocation": "aws-marketplace/suse-sles-sap-15-sp3-byos-v20220719-hvm-ssd-x86_64-*",  
"State": "available",  
"DeprecationTime": "2022-12-16T13:14:00.000Z"  

"ImageId": "ami-0140b01979a357b11",  
"ImageLocation": "aws-marketplace/suse-sles-sap-15-sp3-byos-v20221108-hvm-ssd-x86_64-*",  
"State": "available",  
"DeprecationTime": "2023-06-21T18:37:00.000Z"

]

@lilyeyes lilyeyes temporarily deployed to production August 24, 2023 10:54 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 24, 2023 10:54 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 24, 2023 10:54 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 24, 2023 10:54 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 24, 2023 10:54 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 24, 2023 10:54 — with GitHub Actions Inactive
@lilyeyes lilyeyes force-pushed the deploy-valid-images-past-their-DeprecationTime branch from 34c3890 to 3e35b98 Compare August 25, 2023 06:09
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:10 — with GitHub Actions Inactive
@lilyeyes lilyeyes force-pushed the deploy-valid-images-past-their-DeprecationTime branch from 3e35b98 to 2257178 Compare August 25, 2023 06:49
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 06:50 — with GitHub Actions Inactive
@lilyeyes lilyeyes force-pushed the deploy-valid-images-past-their-DeprecationTime branch from 2257178 to 49e6089 Compare August 25, 2023 07:57
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 07:57 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 07:57 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 07:57 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 07:57 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 25, 2023 07:57 — with GitHub Actions Inactive
@lilyeyes lilyeyes force-pushed the deploy-valid-images-past-their-DeprecationTime branch from cae6c99 to 58a7f16 Compare August 29, 2023 01:47
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 01:47 — with GitHub Actions Inactive
@lilyeyes lilyeyes marked this pull request as ready for review August 29, 2023 02:23
@lilyeyes lilyeyes force-pushed the deploy-valid-images-past-their-DeprecationTime branch from 58a7f16 to 2588c9b Compare August 29, 2023 08:26
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 29, 2023 08:26 — with GitHub Actions Inactive
mpagot
mpagot approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarocarvajald
alvarocarvajald approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilyeyes
Deploy valid AWS images past their DeprecationTime
89dbfb9 
TEAM-8177 - [AWS][Terraform] qe-sap-deployment cannot deploy valid images past their DeprecationTime
@lilyeyes lilyeyes force-pushed the deploy-valid-images-past-their-DeprecationTime branch from 2588c9b to 89dbfb9 Compare August 30, 2023 01:27
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@lilyeyes lilyeyes temporarily deployed to production August 30, 2023 01:27 — with GitHub Actions Inactive
@mpagot mpagot merged commit 5750f21 into SUSE:main Aug 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpagot mpagot mpagot approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilyeyes @alvarocarvajald @mpagot