Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptimizationOptimJL.Optim.BFGS() missing tests for user-supplied derivatives (grad), upper/lower bounds, and the combination #755

Closed
sjdaines opened this issue May 21, 2024 · 0 comments · Fixed by #759
Closed

OptimizationOptimJL.Optim.BFGS() missing tests for user-supplied derivatives (grad), upper/lower bounds, and the combination #755

sjdaines opened this issue May 21, 2024 · 0 comments · Fixed by #759
Labels
bug Something isn't working

Comments

@sjdaines
Copy link
Contributor

sjdaines commented May 21, 2024 •
edited
Loading

Describe the bug 🐞

Releases v3.25.0, v3.25.1 show regressions for OptimizationOptimJL.Optim.BFGS() when used with upper/lower bounds (v3.25.0, see #747) and when used with user-supplied derivative in combination with upper/lower bounds (v3.25.1 #754)

Expected behavior

Ideally tests should exist that catch these problems before release...

Edit - apologies, looks like the real problem here is perhaps how the tests are organized, which makes it difficult to
maintain and add tests in response to issues and fixes?
See #758 (comment)

Minimal Reproducible Example 👇

See #747 (comment), #754

Additional context
@sjdaines sjdaines added the bug Something isn't working label May 21, 2024
sjdaines added a commit to sjdaines/Optimization.jl that referenced this issue May 21, 2024
@sjdaines
Add OptimizationOptimJL.Optim.BFGS() tests for issues 747, 754
764c066 
SciML#754
SciML#747

partially addressing SciML#755

NB: unrelated problem, tests using Optimization.AutoModelingToolkit() were failing,
added code
    @test (sol = solve(prob, Optim.Newton())) isa Any  # test exception not thrown
and similar so exception is caught and other tests run
@sjdaines sjdaines mentioned this issue May 21, 2024
Closed
5 tasks
@Vaibhavdixit02 Vaibhavdixit02 mentioned this issue May 21, 2024
Merged
5 tasks
@sjdaines sjdaines mentioned this issue May 26, 2024
Closed
sjdaines added a commit to sjdaines/Optimization.jl that referenced this issue May 26, 2024
@sjdaines
Add tests for Optim.BFGS() with user-supplied grad and bounds
19da423 
See
SciML#760
SciML#755

- add tests for Optim.BFGS() with user-supplied grad and bounds
- fix wording for error message if bounds specified without either grad function or AD
@sjdaines sjdaines mentioned this issue May 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update OptimizationOptimJL.jl SciML/Optimization.jl
1 participant
@sjdaines