Fix uploading snap to multiple channels #7770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmarcos
reviewed
Jul 26, 2024
FirelightFlagboy
force-pushed
the
fix-snap-upload-multi-channel
branch
from
7a54264 to
6623919
Compare
Currently only the latest args `--release` is used by snapcraft for upload. Rework the script to output the channel values instead of the `--release=$channel` args. Then iterate over the channels to upload the snap to each of them. Co-authored-by: Marcos Medrano <[email protected]>
FirelightFlagboy
force-pushed
the
fix-snap-upload-multi-channel
branch
from
8cf7ab0 to
e253d6c
Compare
mmmarcos
approved these changes
Jul 26, 2024
mmmarcos
reviewed
Jul 26, 2024
| run: | | ||
| set -x | ||
| for channel in $(cat ${{ runner.temp }}/snap-release-channels); do | ||
| snapcraft upload --releases=$channel snap/Parsec_${{ steps.version.outputs.full }}_linux_*.snap |
There was a problem hiding this comment.
Suggested change
| snapcraft upload --releases=$channel snap/Parsec_${{ steps.version.outputs.full }}_linux_*.snap | |
| snapcraft upload --release=$channel snap/Parsec_${{ steps.version.outputs.full }}_linux_*.snap |
mmmarcos
reviewed
Jul 26, 2024
| @@ -1,6 +1,6 @@ | |||
| # Parsec Cloud (https://parsec.cloud) Copyright (c) BUSL-1.1 2016-present Scille SAS | |||
| """ | |||
| For a given Parsec version, this script outputs the `--release=<channel>` options intended for snapcraft. | |||
| For a given Parsec version, this script outputs the `<channel>` value intended to be used in the `--releases=<channel>` option for `snapcraft upload`. | |||
There was a problem hiding this comment.
Approved too quickly ^^
Suggested change
| For a given Parsec version, this script outputs the `<channel>` value intended to be used in the `--releases=<channel>` option for `snapcraft upload`. | |
| For a given Parsec version, this script outputs the `<channel>` value intended to be used in the `--release=<channel>` option for `snapcraft upload`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the latest args
--releaseis used by snapcraft for upload.