Move intake scoring states to separate classes #56
Conversation
|
Thank you for making a pull request! Please make sure to follow the pull request guidelines for this PR. This applies to your commit messages, pull request code, and more! |
There was a problem hiding this comment.
for my information, why is low different from mid and high?
There was a problem hiding this comment.
The speed of the intake seems to be higher when scoring low🤷. I just transferred over what was in the switch statement over to classes
| * @param outtakeSpeed The speed that should be used to outtake the gamepiece | ||
| * @param stateName The name of the scoring state that should be used for logging | ||
| */ | ||
| protected ScoringState(double outtakeSpeed, String stateName) { |
There was a problem hiding this comment.
This interface also seems like it could be simplified if we made all the strategies handle things the same way
There was a problem hiding this comment.
So, that was the approach I was trying to make in the beginning. But I found that it would just overcomplicate it if a state had different speeds for cones and cubes
There was a problem hiding this comment.
Any suggestions on how I could maybe improve it so every state could be handled the same?
kaleb-dodd
deleted the
51/move-intake-scoring-states-to-separate-classes
branch
Description
Moved the scoring states for the intake to separate classes to improve organization and to remove the large conditional block
Fixes #51
Type of change
How Has This Been Tested?
N/A
Checklist: