[BYOC] Fix type errors when creating custom BYOC components that use context SDKs #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type we have in @sitecore/components/context. If an invalid SDK is passed somehow then we return a rejected promise instead. Also import @sitecore/components/context in byoc/index so that the augmented types are included by default.
kendoce
approved these changes
Nov 22, 2023
ambrauer
added a commit
that referenced
this pull request
Nov 22, 2023
…context SDKs (#1675) * Remove undefined from getSDK return type. This matches the augmented type we have in @sitecore/components/context. If an invalid SDK is passed somehow then we return a rejected promise instead. Also import @sitecore/components/context in byoc/index so that the augmented types are included by default. * CHANGELOG update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR fixes type errors when creating custom BYOC component that use context SDKs (i.e. Events Cloud SDK).
undefinedfromgetSDKreturn type. This matches the augmented type we have in@sitecore/components/context. If an invalid SDK is passed somehow then we return a rejected promise instead.import @sitecore/components/contextin byoc/index so that the augmented types are included by default.Testing Details
Types of changes