Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC] Fix type errors when creating custom BYOC components that use context SDKs #1675

Merged
merged 2 commits into from
Nov 22, 2023
Merged

[BYOC] Fix type errors when creating custom BYOC components that use context SDKs #1675

merged 2 commits into from
Nov 22, 2023

Commits on Nov 22, 2023

  1. Remove undefined from getSDK return type. This matches the augmented … 

    …type we have in @sitecore/components/context. If an invalid SDK is passed somehow then we return a rejected promise instead.

Also import @sitecore/components/context in byoc/index so that the augmented types are included by default.
    @ambrauer
    ambrauer committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0f5a808 View commit details
    Browse the repository at this point in the history

  2. CHANGELOG update

    @ambrauer
    ambrauer committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    5d0ebca View commit details
    Browse the repository at this point in the history