Rework Potions #4183
Draft
Rework Potions #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes changes to ExprPotionEffect and adds a new converter to try and keep some syntax working (it is also syntax that flows nicely)
APickledWalrus
added
the
enhancement
|
Marking as a draft again as more in-depth changes are now planned |
Closed
Merged
Modules do not exist yet so it's not really one
|
I don't agree with PotionEffectType to PotionEffect as a converter because you can simply do What converter you would need is PotionEffect to PotionEffectType. |
|
I've now pushed my major changes that have been sitting locally for a while now. This PR depends on #4573, so there is currently some temporary stuff going on to register the potion stuff. |
skript.bukkit -> skriptbukkit
This can be obtained from the addon instance
Allows converting SyntaxInfos back into Builders
Fixes current test failures
|
|
Other miscellaneous fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes to EffPotion to have it follow vanilla behavior. This was done by reworking the whole thing to only use the PotionEffect class that Skript now supports (as of 2.5.2 iirc)
I added two new syntax options to EffPotionEffect as well. This allows users to create PotionEffects from syntax such as
swiftness 2I also added a converter that converts PotionEffectTypes into PotionEffects. This allows a user to do something like:
apply speed to player for 5 secondsThere are still some changes to be made, so I am opening this as a draft.
It is worth nothing that the default duration from the /effect command is 30 seconds, so we should probably change that internally too.
NOTE: This PR contains breaking syntax changes. It should be merged in a future version, such as 2.6.1 or even as far as 2.7 (that can be decided).
Target Minecraft Versions: Any
Requirements: None
Related Issues: #4178