Added Unknown command event

[7othifaPS]

Adds the [player] unknown command event to skript

with event-value unknown command( |-)message

Related Issue: #1655

[EquipableMC]

i'd merge under dev/feature

[7othifaPS]

idk why it didn't merge it

[mpschorr]

a team member has to approve it

[7othifaPS]

how would i mention it to the issue that is related to it

[AyhamAl-Ali]

Thank you for your contribution ⚡

Here are few notes :)

We should also add support for this in ExprCommand and likely add some support in EvtCommand (like adding a new syntax to ignore unknown commands)

[7othifaPS]

Thank you for your contribution ⚡

Here are few notes :)

We should also add support for this in ExprCommand and likely add some support in EvtCommand (like adding a new syntax to ignore unknown commands)

oh ight, i'll check notes in the morning

[7othifaPS]

Done, i did all notes

I put the event in SimpleEvents, and the message in ExprMessage. I committed the changes but how do i show them here

[AyhamAl-Ali]

Done, i did all notes

I put the event in SimpleEvents, and the message in ExprMessage. I committed the changes but how do i show them here

You need to push them to your fork on branch ilikeskript

[7othifaPS]

it rejects it for some reason

[AyhamAl-Ali]

it rejects it for some reason

You need to switch upstream to your fork not origin

[7othifaPS]

i think i did it?

it should be committed here

[AyhamAl-Ali]

This should also add support for event values

[7othifaPS]

I did the things you said but for the check if class exists, the event isn't paper, its bukkit

[7othifaPS]

there

[Pikachu920]

thank you for your contribution! can you please add an event value for the command sender, and support for ExprCommand/ExprArgument? let me know if you need any help

[7othifaPS]

There, tell me if something's wrong

sorry for having all these, its my first time :)

[7othifaPS]

Oh wait, how should i add a player event-value to the event? since it doesn't have its own class

[Fusezion]

Test should still be added

[Moderocky]

This could have a test.

[TheLimeGlass]

Does the JUnit have any 'ensure's set up to ensure that the unknown command event gets called and returns what is thought of for the JUnit?

[Efnilite]

this test won't ever get called on its own, you need to call the event in the java JUnit package and then ensure that you can modify the unknown command message correctly. look at other expressions for examples

[APickledWalrus]

Does this fire for console commands? You might be able to get away with execute console command "fakecommand" in a test

[Moderocky]

This is not a test.