Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse proxy location when set #1394

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Reuse proxy location when set #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions skyvern-frontend/src/routes/workflows/WorkflowRun.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { statusIsFinalized, statusIsRunningOrQueued } from "../tasks/types";
import { useWorkflowQuery } from "./hooks/useWorkflowQuery";
import { useWorkflowRunQuery } from "./hooks/useWorkflowRunQuery";
import { cn } from "@/util/utils";
import { ProxyLocation } from "@/api/types";

function WorkflowRun() {
const { workflowRunId, workflowPermanentId } = useParams();
Expand Down Expand Up @@ -79,6 +80,8 @@ function WorkflowRun() {
const workflowRunIsFinalized = workflowRun && statusIsFinalized(workflowRun);

const parameters = workflowRun?.parameters ?? {};
const proxyLocation =
workflowRun?.proxy_location ?? ProxyLocation.Residential;

const title = workflowIsLoading ? (
<Skeleton className="h-9 w-48" />
Expand Down Expand Up @@ -189,6 +192,7 @@ function WorkflowRun() {
to={`/workflows/${workflowPermanentId}/run`}
state={{
data: parameters,
proxyLocation,
}}
>
<PlayIcon className="mr-2 h-4 w-4" />
Expand Down
9 changes: 8 additions & 1 deletion skyvern-frontend/src/routes/workflows/WorkflowRunParameters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ function WorkflowRunParameters() {
(parameter) => parameter.parameter_type === "workflow",
);

const proxyLocation = location.state
? (location.state.proxyLocation as ProxyLocation)
: null;

const initialValues = location.state?.data
? location.state.data
: workflowParameters?.reduce(
Expand Down Expand Up @@ -95,7 +99,10 @@ function WorkflowRunParameters() {
initialValues={initialValues}
workflowParameters={workflowParameters}
initialSettings={{
proxyLocation: workflow.proxy_location ?? ProxyLocation.Residential,
proxyLocation:
proxyLocation ??
workflow.proxy_location ??
ProxyLocation.Residential,
webhookCallbackUrl: workflow.webhook_callback_url ?? "",
}}
/>
Expand Down
Loading