Reuse proxy location when set #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Reuse `proxyLocation` when rerunning workflows, defaulting to `ProxyLocation.Residential` if not set, in `WorkflowRun` and `WorkflowRunParameters`. > > - **Behavior**: > - Reuse `proxyLocation` when rerunning workflows in `WorkflowRun` and `WorkflowRunParameters`. > - Default to `ProxyLocation.Residential` if `proxyLocation` is not set. > - **State Management**: > - Pass `proxyLocation` in `state` when navigating to rerun a workflow in `WorkflowRun`. > - Retrieve `proxyLocation` from `location.state` in `WorkflowRunParameters`. > - **Initial Settings**: > - Set `proxyLocation` in `initialSettings` of `RunWorkflowForm` in `WorkflowRunParameters`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 04fd4ccfaa4b55918b808e1d046b008777878b2d. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a64da92 in 18 seconds
More details
- Looked at
57lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:192
- Draft comment:
Use theproxyLocationvariable instead of hardcoding "RESIDENTIAL" to ensure consistency with the rerun logic.
proxy_location: proxyLocation,
- Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_Wp3ozxrINm1iCHel
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a64da92 in 12 seconds
More details
- Looked at
57lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:195
- Draft comment:
Ensure that theproxyLocationis used consistently throughout the rerun logic to avoid discrepancies. - Reason this comment was not posted:
Confidence changes required:50%
The code inWorkflowRun.tsxandWorkflowRunParameters.tsxis mostly consistent with the PR description. However, there is a hardcoded value forproxy_locationin the cURL command that should be using theproxyLocationvariable instead.
Workflow ID: wflow_pL1ducMBkb94RLBY
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Reuse
proxyLocationwhen rerunning workflows, defaulting toProxyLocation.Residentialif not set, inWorkflowRunandWorkflowRunParameters.proxyLocationwhen rerunning workflows inWorkflowRunandWorkflowRunParameters.ProxyLocation.ResidentialifproxyLocationis not set.proxyLocationinstatewhen navigating to rerun a workflow inWorkflowRun.proxyLocationfromlocation.stateinWorkflowRunParameters.proxyLocationininitialSettingsofRunWorkflowForminWorkflowRunParameters.This description was created by
for a64da92. It will automatically update as commits are pushed.