Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: VRServer gracefully shutdown #632

Merged
merged 20 commits into from
Apr 11, 2023
Merged

feat: VRServer gracefully shutdown #632

merged 20 commits into from
Apr 11, 2023

Conversation

marcozzxx810
Copy link
Contributor

@marcozzxx810 marcozzxx810 commented Mar 19, 2023 •
edited
Loading

  • add log cleanup function to shutdown Hook
  • setting up SIGTERM for window and Linux system

@marcozzxx810 marcozzxx810 changed the title feat: VRServer is gracefully shutdown feat: VRServer gracefully shutdown Mar 19, 2023
@ButterscotchV ButterscotchV added Priority: Normal The default priority Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Mar 21, 2023
@marcozzxx810 marcozzxx810 marked this pull request as ready for review March 29, 2023 15:41
TheButlah
TheButlah requested changes Mar 29, 2023
View reviewed changes
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
@marcozzxx810 marcozzxx810 marked this pull request as draft March 31, 2023 16:04
@marcozzxx810 marcozzxx810 marked this pull request as ready for review March 31, 2023 16:45
TheButlah
TheButlah reviewed Apr 1, 2023
View reviewed changes
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
TheButlah
TheButlah approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@TheButlah TheButlah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring my review to @ImUrX since they are making changes.

ImUrX
ImUrX requested changes Apr 11, 2023
View reviewed changes
gui/src-tauri/src/main.rs Outdated Show resolved Hide resolved
@ImUrX ImUrX self-requested a review April 11, 2023 14:50
@Eirenliel Eirenliel merged commit ccef1df into SlimeVR:main Apr 11, 2023
@ImUrX ImUrX mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars left review comments

@TheButlah TheButlah TheButlah approved these changes

@ImUrX ImUrX ImUrX approved these changes

@Eirenliel Eirenliel Eirenliel approved these changes

@ButterscotchV ButterscotchV Awaiting requested review from ButterscotchV ButterscotchV is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

Assignees
No one assigned
Labels
Area: Server Related to the server Priority: Normal The default priority Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcozzxx810 @Eirenliel @ImUrX @TheButlah @FabianLars @ButterscotchV