Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Chinese localization #4

Merged
merged 9 commits into from
Dec 20, 2023
Merged

Conversation

Wheatley11
Copy link
Contributor

简体中文本地化

Copy link
Contributor

@qznfbnj qznfbnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

随便看了一下,也有参考 MgRbExtras-i18n,有空再仔细看。
I took a casual look with reference to MgRbExtras-i18n , I will take a closer look when I have time.

src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
@SrRapero720
Copy link
Owner

SrRapero720 commented Dec 18, 2023

Thank you very much for your contributions, I would like to collaborate but I have zero knowledge of the language.
I will be waiting for you to confirm that everything is done and ready to do the merge.

@qznfbnj
Copy link
Contributor

qznfbnj commented Dec 18, 2023

Thank you very much for your contributions, I would like to collaborate but I have zero knowledge of the language.
I will be waiting for you to confirm that everything is done and ready to do the merge.

Hi! Will L24-25 and L30-31 confuse users? Of course I know these are sentences taken from Rubidium Extras. Can I translate them to 开启Toggles on)?
L24-25

  "embeddium.plus.options.fog.title": "Enable fog",
  "embeddium.plus.options.fog.desc": "Toggles off all fog in the overworld",

L30-31

  "embeddium.plus.options.culling.entity.title": "Enable Max Entity Distance",
  "embeddium.plus.options.culling.entity.desc": "Toggles off entity culling.",

Also, will translating Pixels and Blocks like this cause problems?
image

Copy link
Contributor

@qznfbnj qznfbnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最终小修改

  1. 删去之前 Review 时失误引入的空行(extra spaces)
  2. displayfps.desc 中的 判断性能 改为 评估性能,并将句号从英文半角改为中文全角
  3. displayfps.position.desc 中的 几个 改为 一定
  4. darkness.desc 中删除重复的 照明 并改为 光照
  5. dynlights.entities.descdynlights.blockentities.desc 中的 照明 改为 光照
  6. 增加了 PixelsBlocks 的翻译(units translation)

话说 渐显淡入 你更喜欢前者么

src/main/resources/assets/embeddiumplus/lang/zh_cn.json Outdated Show resolved Hide resolved
@SrRapero720
Copy link
Owner

Hi! Will L24-25 and L30-31 confuse users? Of course I know these are sentences taken from Rubidium Extras. Can I translate them to 开启(Toggles on)?
L24-25

yes, my bad for not re-check it again.
At the moment, you can fix the translation. I will release a minor update with all translations, because next update is gonna take me a while, and i need to do a big cleanup of that thing

@SrRapero720
Copy link
Owner

SrRapero720 commented Dec 19, 2023

Also, will translating Pixels and Blocks like this cause problems?

yes, please don't do that, thats a small issue and requires to be solved on sodium/embeddium

@SrRapero720
Copy link
Owner

oh wait, nevermind, is a issue of emb++
again my bad, i didn't notice about it.

@SrRapero720
Copy link
Owner

after you solve it i will merge PR

Copy link
Contributor

@qznfbnj qznfbnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得中文翻译没必要写出 切换开启/关闭。所以 desc 保留和 title 对应的 开启。不过 jei.desc 仍翻译为 隐藏(toggle off),因为开启此项时会隐藏JEI物品列表的物品。
I think there is no need to write toggle on/off in the Chinese translation. So desc retains the toggle on corresponding to title. However, jei.desc is still translated as hide (toggle off), because when this option is turned on, items in the JEI item list will be hidden.

@qznfbnj
Copy link
Contributor

qznfbnj commented Dec 20, 2023

There is no problem on my side now.

@SrRapero720 SrRapero720 merged commit 339f765 into SrRapero720:1.20.1 Dec 20, 2023
1 check passed
SrRapero720 pushed a commit that referenced this pull request Feb 12, 2024
* Simplified Chinese localization 简体中文本地化

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

* Update src/main/resources/assets/embeddiumplus/lang/zh_cn.json

Co-authored-by: 其智乃反不能及 <[email protected]>

---------

Co-authored-by: 其智乃反不能及 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Translation Marked as a translation Status: Queue to Merge Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants