Add CI job for helm chart #73
Conversation
kasia-kujawa
force-pushed
the
kk-add-helm-job
branch
from
c791b29 to
6c19d66
Compare
| - uses: actions/checkout@v2 | ||
| - uses: imranismail/setup-kustomize@v1 | ||
| - uses: WyriHaximus/github-action-helm3@v2 | ||
| - uses: AbsaOSS/[email protected] |
There was a problem hiding this comment.
Why not just v1 to get the upgrades?
There was a problem hiding this comment.
I'll change this :) But firstly helm chart needs to be fixed in #75
There was a problem hiding this comment.
I've tried to change to v1 but with that change it does not work:
Error: Unable to resolve action `AbsaOSS/k3d-action@v1`, unable to find version `v1`
| run: make TAG=registry.localhost:5000/sumologic/tailing-sidecar:test | ||
| - name: Build tailing sidecar operator | ||
| working-directory: ./operator | ||
| run: make docker-build IMG="registry.localhost:5000/sumologic/tailing-sidecar-operator:test" | ||
| - name: Push tailing sidecar operator | ||
| working-directory: ./operator | ||
| run: make docker-push IMG="registry.localhost:5000/sumologic/tailing-sidecar-operator:test" |
There was a problem hiding this comment.
Only now I see the inconsistency between TAG and IMG. Not a blocker but I guess it would be nice to make those consistent
There was a problem hiding this comment.
There should have different variables names for these if we want to introduce #67, maybe they should have then different names like SIDECAR_IMG and OPERATOR_IMG but this should be done in different PR as modification will be made in many places.
There was a problem hiding this comment.
I've opened issue for this change: #76
kasia-kujawa
force-pushed
the
kk-add-helm-job
branch
from
6c19d66 to
2da3ea4
Compare
kasia-kujawa
force-pushed
the
kk-add-helm-job
branch
2 times, most recently
from
bf25588 to
5ad4ad2
Compare
kasia-kujawa
force-pushed
the
kk-add-helm-job
branch
from
5ad4ad2 to
2f6580c
Compare
No description provided.