Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job for helm chart #73

Merged
merged 1 commit into from
Mar 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/workflows/pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,49 @@ jobs:
- name: Check logs
working-directory: ./operator
run: make test-examples

deploy-helm-chart:
name: Deploy helm chart for tailing sidecar operator
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: imranismail/setup-kustomize@v1
- uses: AbsaOSS/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just v1 to get the upgrades?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬆️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change this :) But firstly helm chart needs to be fixed in #75

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to change to v1 but with that change it does not work:

Error: Unable to resolve action `AbsaOSS/k3d-action@v1`, unable to find version `v1`

id: single-cluster
name: Create single k3d Cluster with Registry
with:
cluster-name: "test-cluster"
use-default-registry: true
args: >-
--agents 1
--no-lb
--k3s-server-arg "--no-deploy=traefik,servicelb,metrics-server"
- name: Add Helm
uses: WyriHaximus/github-action-helm3@v2
- name: Deploy cert-manager
working-directory: ./operator
run: make deploy-cert-manager
- name: Build and push tailing sidecar image
working-directory: ./sidecar
run: make TAG=registry.localhost:5000/sumologic/tailing-sidecar:test
- name: Build tailing sidecar operator
working-directory: ./operator
run: make docker-build IMG="registry.localhost:5000/sumologic/tailing-sidecar-operator:test"
- name: Push tailing sidecar operator
working-directory: ./operator
run: make docker-push IMG="registry.localhost:5000/sumologic/tailing-sidecar-operator:test"
Comment on lines +136 to +142
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only now I see the inconsistency between TAG and IMG. Not a blocker but I guess it would be nice to make those consistent

Copy link
Contributor Author

@kasia-kujawa kasia-kujawa Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should have different variables names for these if we want to introduce #67, maybe they should have then different names like SIDECAR_IMG and OPERATOR_IMG but this should be done in different PR as modification will be made in many places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened issue for this change: #76

- name: Deploy Helm chart
working-directory: ./helm
run: helm upgrade --install test-release ./tailing-sidecar-operator -f tests/values.yaml -n tailing-sidecar-system --create-namespace
- name: Wait for operator to be ready
run: kubectl wait --for=condition=ready --timeout 60s pod -l app.kubernetes.io/name=tailing-sidecar-operator -n tailing-sidecar-system
- name: Deploy examples
working-directory: ./operator
run: make deploy-examples
- name: Wait for logs to be generated
run: sleep 5
- name: Check Pods
run: kubectl get pods -n tailing-sidecar-system
- name: Check logs
working-directory: ./operator
run: make test-examples
9 changes: 9 additions & 0 deletions helm/tests/values.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
operator:
image:
repository: registry.localhost:5000/sumologic/tailing-sidecar-operator
tag: test

sidecar:
image:
repository: registry.localhost:5000/sumologic/tailing-sidecar
tag: test