Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider storage config passed in when launching sessions #565

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: consider storage config passed in when launching sessions #565

merged 1 commit into from
Dec 10, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 10, 2024

Moving
SwissDataScienceCenter/renku-notebooks#1912 from ntoebooks repo.

@olevski olevski requested a review from a team as a code owner December 10, 2024 08:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12251907435

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.006%) to 85.731%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/api/schemas/cloud_storage.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/db.py 2 85.68%
components/renku_data_services/storage/blueprints.py 2 95.69%
components/renku_data_services/storage/models.py 2 84.11%
Totals Coverage Status
Change from base Build 12230524828: 0.006%
Covered Lines: 14522
Relevant Lines: 16939
💛 - Coveralls

@olevski olevski merged commit a4e25b0 into main Dec 10, 2024
15 checks passed
@olevski olevski deleted the notebooks-catchup-1 branch December 10, 2024 10:02
@olevski olevski mentioned this pull request Dec 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panaetius Panaetius Panaetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olevski @coveralls @Panaetius @m-alisafaee