-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several minor data-connector bugs #3400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
force-pushed
the
ciyer/data-connector-bugs
branch
from
November 14, 2024 09:51
4394397
to
6a8eadc
Compare
This was
linked to
issues
Nov 14, 2024
ciyer
force-pushed
the
ciyer/data-connector-bugs
branch
from
November 15, 2024 13:28
bc0f3de
to
d3d901d
Compare
ciyer
temporarily deployed
to
renku-ci-ui-3400
November 15, 2024 13:48 — with
GitHub Actions
Inactive
You can access the deployment of this PR at https://renku-ci-ui-3400.dev.renku.ch |
ciyer
temporarily deployed
to
renku-ci-ui-3400
November 15, 2024 14:21 — with
GitHub Actions
Inactive
leafty
reviewed
Nov 15, 2024
client/src/features/projectsV2/fields/ProjectNamespaceFormField.tsx
Outdated
Show resolved
Hide resolved
leafty
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/deploy renku=feat-jupyter-free-sessions renku-data-services=main amalthea-sessions=main renku-notebooks=master extra-values=amalthea-sessions.deployCrd=false