Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several minor data-connector bugs #3400

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Fix several minor data-connector bugs #3400

merged 4 commits into from
Nov 18, 2024

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Nov 14, 2024

  • minor: fix DOM structure issue
  • minor: use dropdown z-index for namespace select menu
  • fix: only save credentials when there are sensitive values

/deploy renku=feat-jupyter-free-sessions renku-data-services=main amalthea-sessions=main renku-notebooks=master extra-values=amalthea-sessions.deployCrd=false

@ciyer ciyer force-pushed the ciyer/data-connector-bugs branch from bc0f3de to d3d901d Compare November 15, 2024 13:28
@ciyer ciyer temporarily deployed to renku-ci-ui-3400 November 15, 2024 13:48 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3400.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-3400 November 15, 2024 14:21 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review November 15, 2024 15:08
@ciyer ciyer requested a review from a team as a code owner November 15, 2024 15:08
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciyer ciyer merged commit 7b318bc into main Nov 18, 2024
19 checks passed
@ciyer ciyer deleted the ciyer/data-connector-bugs branch November 18, 2024 10:23
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants