chore(gitlab): update gitlab chart - bump container image version, change redis chart repo, bump chart version #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange redis chart repo, bump chart version
There had been version bumps to the gitlab helm charts which did not appear to be tracked in the renku repo with version 0.6.8 being the last published release and 0.6.9 being a WIP.
…or publishing gitlab and one for publishing renku
rokroskar
reviewed
Jul 27, 2022
| # chart. As renku moves to use of the standard gitlab cloud native chart, this | ||
| # will become redundnat but for now it is still in use. | ||
| # | ||
| # To use this, you will need to remove the chartpress.yaml for building renku and |
There was a problem hiding this comment.
this seems sub-optimal - can we contribute a --file option to the upstream?
There was a problem hiding this comment.
Sounds v doable - prob just adding an arg with a default and prob a test.
I can look into it.
There was a problem hiding this comment.
I made jupyterhub/chartpress#170
|
what's the status here @seanrmurphy ? |
|
Closing - superceded by #2820. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with v0.6.0 of this helm chart which impacted how prometheus was scraping data from gitlab; that is the primary driver for the new release of this chart (#2656).
It was also noticed that the dependent redis chart must be changed due to the issues with bitnami changing how they publish artifacts and also the gitlab container image was a bit out of date.
This has been deployed within a dedicated namespace, with the renku gitlab dep pointing at this local version 0.6.1 of the gitlab helm chart.