-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gitlab): update gitlab chart - bump container image version, change redis chart repo, bump chart version #2668
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
153fca4
chore(gitlab): update gitlab chart - bump container image version, ch…
seanrmurphy 54f5000
chore(gitlab): bump version number of gitlab helm chart to 0.7.0
seanrmurphy fcf5d18
Merge branch 'master' into upgate-gitlab-helm-chart
pameladelgado 30ca430
Merge branch 'master' into upgate-gitlab-helm-chart
seanrmurphy 23f2052
chore(chartpress): separate chartpress into two distinct files, one f…
seanrmurphy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# this file should be used as and when necessary to build the renku gitlab helm | ||
# chart. As renku moves to use of the standard gitlab cloud native chart, this | ||
# will become redundnat but for now it is still in use. | ||
# | ||
# To use this, you will need to remove the chartpress.yaml for building renku and | ||
# replace it with this file (it seems chartpress cannot work with a file other than | ||
# one called chartpress.yaml). | ||
# | ||
# To build and push a release candidate chart do this: | ||
# | ||
# chartpress --publish --tag x.y.z-rc.Q | ||
# | ||
# To publish a chart which is not a release candidate do this, making sure that | ||
# your appropriate merges/commits are made before doing this: | ||
# | ||
# chartpress --publish --tag x.y.z | ||
# | ||
|
||
charts: | ||
- name: helm-chart/gitlab | ||
imagePrefix: renku/ | ||
repo: | ||
git: SwissDataScienceCenter/helm-charts | ||
published: https://swissdatasciencecenter.github.io/helm-charts | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
dependencies: | ||
- name: redis | ||
version: 10.7.11 | ||
repository: "https://charts.bitnami.com/bitnami" | ||
repository: "https://raw.githubusercontent.com/bitnami/charts/pre-2022/bitnami" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
|
||
image: | ||
repository: gitlab/gitlab-ce | ||
tag: 12.9.5-ce.0 | ||
tag: 14.10.5-ce.0 | ||
pullPolicy: IfNotPresent | ||
|
||
ssh: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems sub-optimal - can we contribute a
--file
option to the upstream?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds v doable - prob just adding an arg with a default and prob a test.
I can look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made jupyterhub/chartpress#170