Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gitlab): update gitlab chart - bump container image version, change redis chart repo, bump chart version #2668

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions chartpress-gitlab.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# this file should be used as and when necessary to build the renku gitlab helm
# chart. As renku moves to use of the standard gitlab cloud native chart, this
# will become redundnat but for now it is still in use.
#
# To use this, you will need to remove the chartpress.yaml for building renku and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems sub-optimal - can we contribute a --file option to the upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds v doable - prob just adding an arg with a default and prob a test.

I can look into it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# replace it with this file (it seems chartpress cannot work with a file other than
# one called chartpress.yaml).
#
# To build and push a release candidate chart do this:
#
# chartpress --publish --tag x.y.z-rc.Q
#
# To publish a chart which is not a release candidate do this, making sure that
# your appropriate merges/commits are made before doing this:
#
# chartpress --publish --tag x.y.z
#

charts:
- name: helm-chart/gitlab
imagePrefix: renku/
repo:
git: SwissDataScienceCenter/helm-charts
published: https://swissdatasciencecenter.github.io/helm-charts

12 changes: 2 additions & 10 deletions chartpress.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
charts:
## gitlab and renku chart versions are not evolving together. Uncomment
## this only when explicitly building the gitlab chart and set the appropriate tag.
# - name: gitlab
# imagePrefix: renku/
# repo:
# git: SwissDataScienceCenter/helm-charts
# published: https://swissdatasciencecenter.github.io/helm-charts
# paths:
# - ./gitlab
# this chartpress config file can be used to build and publish the renku helm chart

charts:
- name: helm-chart/renku
resetTag: latest
imagePrefix: renku/
Expand Down
2 changes: 1 addition & 1 deletion helm-chart/gitlab/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ apiVersion: v1
appVersion: '1.0'
description: A Helm chart for the Renku Gitlab server
name: gitlab
version: 0.6.0
version: 0.7.0
2 changes: 1 addition & 1 deletion helm-chart/gitlab/requirements.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
dependencies:
- name: redis
version: 10.7.11
repository: "https://charts.bitnami.com/bitnami"
repository: "https://raw.githubusercontent.com/bitnami/charts/pre-2022/bitnami"
2 changes: 1 addition & 1 deletion helm-chart/gitlab/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

image:
repository: gitlab/gitlab-ce
tag: 12.9.5-ce.0
tag: 14.10.5-ce.0
pullPolicy: IfNotPresent

ssh:
Expand Down