-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface TOS + privacy policy better #1646
Conversation
I feel like adjustments to terms and privacy policies should be done carefully and deliberately. I'm also not really happy with some of the changes requested here. Like using weird terms like "stewards" (I had to look it up), and things like "posts can be deleted, but not un-sent", what does that even mean? I'm also not a fan of using "FWIW" (which I also had to look up) and all other kinds of unexplained abbreviations. Like, the title here says "privacy policy better", but I don't know about that... |
Agreed. These are only suggestions, and I don't doubt the wording can be improved for the benefit of non-native speakers.
"Be mindful of what you share." But now I see that's a shorter way of putting it, which is what I was going for...
Fair, I was just full of anti-Google sentiment at that point (hence #1647). Where else did I abbreviate?
It's possible to pi-hole Google (and Cloudflare but that doesn't break anything), but until #1647 is resolved, those people won't be able to create an account or log in. As it stands, it's not obvious what the cause is or whether that's intentional. (We can't assume every pi-hole user's first thought would be to check for blocked requests.)
(Surface (TOS + privacy policy)) better. I am of the opinion that the current privacy policy has a lot of problems (for one, where is user data being stored or processed?), but that's outside the scope of this PR and not really my call to make. |
I'd honestly start a public discussion somewhere, making some points and letting other people and staff contribute ideas as well. On the forum, on the github issue tracker, in a discord thread, would all probably be better places to place suggestions than inside a PR. |
Suggestions don't explain much without providing all the relevant context and reasons, ideally in a way that people who don't know anything about server technology could understand. And yes it should be a forum thread. |
No discussion of those topics on the site for 2 weeks suggests me we don't need to leave this PR open indefinitely. If there's a discussion, and an agreement, the agreed on changes can be suggested separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look ok IMO. The rest is a site talk.
@@ -49,6 +49,10 @@ | |||
</div> | |||
<span asp-validation-for="Coppa" class="text-danger"></span> | |||
</form-group> | |||
<form-group> | |||
Also make sure you've read the <a href="/SiteRules">Site Rules</a>.<br/> | |||
Your data will be stored according to our <a href="/System/PrivacyPolicy">Privacy Policy</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it weird to link to a System page that clearly says "not a page intended for standalone viewing"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just copied the login page:
Please view our <a href="/System/PrivacyPolicy">Privacy Policy</a> |
I agree the warning could confuse new users.
Untested.
I'd also like to suggest these changes to
/SiteRules
:And this change to
/System/PrivacyPolicy
: