Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface TOS + privacy policy better #1646

Merged
merged 5 commits into from
Sep 2, 2023
Merged

Surface TOS + privacy policy better #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f969e36
Link TOS + privacy policy from signup form
YoshiRulz Aug 16, 2023
addc605
Add link to `/SiteRules` to global footer
YoshiRulz Aug 16, 2023
5719c2f
Change wording
YoshiRulz Sep 2, 2023
9dbf108
Change wording
YoshiRulz Sep 2, 2023
067cf3c
Update TASVideos/Pages/Account/Register.cshtml
vadosnaprimer Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions TASVideos/Pages/Account/Register.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@
</div>
<span asp-validation-for="Coppa" class="text-danger"></span>
</form-group>
<form-group>
Also make sure you've read the <a href="/SiteRules">Site Rules</a>.<br/>
Your data will be stored according to our <a href="/System/PrivacyPolicy">Privacy Policy</a>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it weird to link to a System page that clearly says "not a page intended for standalone viewing"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just copied the login page:

tasvideos/TASVideos/Pages/Account/Login.cshtml

Line 34 in ba98795

Please view our <a href="/System/PrivacyPolicy">Privacy Policy</a>

I agree the warning could confuse new users.

</form-group>
<environment exclude="Development">
<form-group>
<recaptcha />
Expand Down
3 changes: 2 additions & 1 deletion TASVideos/Pages/Shared/_Layout.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@
<button id="button-scrolltop" class="d-none position-fixed px-3 py-1 m-2 bottom-0 end-0 btn btn-primary fa fa-caret-up"></button>
<row class="justify-content-start align-items-center">
<p class="col-auto my-auto">
&copy; @DateTime.UtcNow.Year - TASVideos <a href="https://github.com/TASVideos/tasvideos/commit/@ViewData["VersionSha"]">v@(ViewData["Version"])</a> - <a href="/api">API</a>
&copy; @DateTime.UtcNow.Year - TASVideos <a href="https://github.com/TASVideos/tasvideos/commit/@ViewData["VersionSha"]">v@(ViewData["Version"])</a>
- <a href="/SiteRules">Terms</a> - <a href="/api">API</a>
</p>
</row>
</footer>
Expand Down