-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring boot 3 1 x #2421
Spring boot 3 1 x #2421
Conversation
lib/taskana-cdi-example/src/main/java/pro/taskana/example/ExampleBootstrap.java
Outdated
Show resolved
Hide resolved
lib/taskana-cdi-example/src/main/java/pro/taskana/example/ExampleBootstrap.java
Outdated
Show resolved
Hide resolved
594ae5a
to
3e24eab
Compare
Hello everyone, a short explanation about the QualityGates The CodeCoverage is mainly broken by the new module I have fixed all code smells related to Taskana. It was only CDI. All other code smells concern the new module The 2 security hotspots are also in the The code duplication is also in the new module |
Hi @arolfes We could consider excluding the new module from the Sonar analysis for now, what do you think? |
7b32dbb
to
5418aa1
Compare
5418aa1
to
9caf7c6
Compare
Hi @gitgoodjhe , I really like your idea. I did some tweaks :) looks good to me :) |
…g-parent as long as a newer release of dmn-xlsx-converter is missing, we need to care that the underlying docx4j version is using jakarta instead of javax So all classes are copied from this PR camunda-community-hub/camunda-dmn-xlsx#53
9caf7c6
to
cc6c482
Compare
Upgrading to Spring Boot 3.1.x required an upgrade to jakarta.
The Wildfly server 25.0.1 does not yet support jakarta, so it had to be upgraded as well.
With Spring Boot 3.1.X, SLF4J 2.0.X was also added to TASKANA.
We tried to adapt as little production & test code as possible, except for the imports.
However, this was not possible in the CDI module.
Here a new method with an empty body had to be implemented so that the PostConstruct method is executed first.
is executed first.
The other changes in the CDI module concern the switch to Wildfly 27 and the upgrade of the arquillian test module.
After reviewing the sonar-cloud results, I switched from property injection to constructor injection for all cdi related classes.
The taskana-routing-rest module could no longer be built because it had a dependency on the
dmn-xlsx-converter
from camunda. This community project has not yet been updated to jakarta. So we cloneddmn-xlsx-converter
and built it as a submodule oftaskana-routing-parent
.We made all necessary changes available to the project as PR and documented them in the clone.
SonarCloud results
https://sonarcloud.io/summary/new_code?id=norman-schmidt_taskana&branch=SPRING_BOOT_3_1_x
All warnings regarding the
dmn-xlsx-converter
will not be fixed for the time being. How this will be handled has yet to be decided.Addendum Nr: 1
In the module
taskana-routing-rest
I switched fromcom.sun.xml.bind:jaxb-core
toorg.glassfish.jaxb:jaxb-core
andcom.sun.xml.bind:jaxb-impl
toorg.glassfish.jaxb:jaxb-runtime
.There is already a discussion about this. #2421 (comment)
Should we stay with glassfish here or switch back to sun?
Addendum Nr: 2
While upgrading to Wildfly 27.0.1 I noticed that a complete EE server is started here.
In my opinion this is not necessary.
Changing the configuration of the Wildfly server at this point can speed up testing considerably.
However, this is not part of the Spring Boot upgrade and should be addressed in a separate ticket.
Release Notes:
For the submitter:
Verified by the reviewer: