Enable some more @typescript-eslint rules #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the error:
error Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
- If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead @typescript-eslint/ban-types
This makes the return type correspond to the boolean that the comment at the interface suggests.
There is a single type signature that does not pass this check in the current code base, so update that signature and enable the lint rule.
ljowen
reviewed
Oct 13, 2024
Remove constructors that just call super() with their arguments and enable @typescript-eslint/no-useless-constructor.
pjonsson
force-pushed
the
enable-more-lint
branch
from
d8a5e28
to
09f6994
Compare
ljowen
approved these changes
Nov 20, 2024
|
Looks good to me too. Thanks @pjonsson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Enable some more @typescript-eslint rules.
These rules seem worthy of keeping enabled so more of these issues don't get into the code base. I don't have a strong opinion that all of them have to be enabled, so if some rule is contentious, just let me know and I'll drop that commit so the rest of the PR can get merged.
Test me
Run
yarn gulp lintand see that the linter passes.Checklist
doc/.