Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: use recommended configuration #7323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 21, 2024

What this PR does

The eslint-recommended configuration
is a subset of recommended, so switch
to the recommended configuration and
remove the rules that are already part
of the recommended configuration.
There are a few rules that result in
numerous errors, so disable them for
now.

Test me

Tested by CI.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

The eslint-recommended configuration
is a subset of recommended, so switch
to the recommended configuration and
remove the rules that are already part
of the recommended configuration.
There are a few rules that result in
numerous errors, so disable them for
now.
@pjonsson pjonsson changed the title ESLint: enable more unused vars checks ESLint: use recommended configuration Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant