Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript folder: rename few folders/files for consistency #24023

Merged
merged 6 commits into from
Apr 21, 2022

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Apr 14, 2022

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text

Complete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:

  • I have previewed all lesson files included in this PR with the Markdown preview tool to ensure the Markdown content is formatted correctly
  • I have ensured all lesson files included in this PR follow the Layout Style Guide

1. Because:

Related to:

2. This PR:

  1. Renames files/folders to snake_case
  2. Renames files/folders to match course structure on the website

3. Additional Information:

Currently, this pull request addresses the following folders:

  1. introduction
  2. organizing-js
  3. finishing-up
  4. js-and-the-backend
  5. js-in-the-real-world

A future pull request will address the rest of the folders in javascript.

01zulfi added 5 commits April 14, 2022 14:11
* javascript/introduction/js101-review.md -> javascript/introduction/a_quick_review.md
* javascript/introduction/introduction.md -> javascript/introduction/how_this_course_will_work.md
reason: to match the lesson title on the website
* rename project_final_js to project_final_javascript
@01zulfi 01zulfi added Status: Do Not Review This issue/PR should not be reviewed until further notice Type: Epic This issue is a larger, unnamed project with several moving parts labels Apr 14, 2022
@01zulfi 01zulfi added Status: Needs Review and removed Status: Do Not Review This issue/PR should not be reviewed until further notice labels Apr 14, 2022
@zachmmeyer
Copy link
Contributor

Just have some conflicts to resolve

@01zulfi 01zulfi merged commit 4ea4c2c into TheOdinProject:main Apr 21, 2022
@01zulfi 01zulfi deleted the javascript-cleanup-part-one branch April 22, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants