Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GHA runners to macos-12 #14

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Jul 1, 2024

This PR was originally opened by @jdblischak (#13). The CI in his PR fails because PRs from external contributors do not have access to the repo's secrets. In this case there is a repo secret in the form of an API token that gives access to TileDB-Cloud arrays.

@DimitrisStaratzis DimitrisStaratzis changed the title update runners to macos-12 Update GHA runners to macos-12 Jul 1, 2024
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually wondering if running CI on macOS is even worth it in the first place. This library is 100% Java code with no direct native dependencies or platform-specific code, and macOS runners are a scarce resource.

@@ -45,7 +45,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ ubuntu-latest, macos-11 ]
os: [ ubuntu-latest, macos-12 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use macos-latest like Ubuntu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos-latest is a dynamic image, so i am trying to avoid updates that could lead to breaking changes. With this in mind we should consider using ubuntu-22.04 instead of ubuntu-latest

@DimitrisStaratzis
Copy link
Contributor Author

I'm actually wondering if running CI on macOS is even worth it in the first place. This library is 100% Java code with no direct native dependencies or platform-specific code, and macOS runners are a scarce resource.

We very rarely run the Ci in this repo and the execution time when it runs is less than a minute. It is good in my opinion to test as many platforms as possible.

@DimitrisStaratzis DimitrisStaratzis merged commit d46b2c4 into main Jul 1, 2024
4 checks passed
@DimitrisStaratzis DimitrisStaratzis deleted the dstara/update_to_macos-12 branch July 1, 2024 15:12
@ihnorton
Copy link
Member

ihnorton commented Jul 1, 2024

It is good in my opinion to test as many platforms as possible.

+1. If it becomes too frequent then we could make macOS nightly only, but it is still good to have a minimal check on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants