Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to rqt_gauges #23

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Rename to rqt_gauges #23

merged 3 commits into from
Dec 28, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Dec 26, 2023

Rename package from rqt_gauges_2 to rqt_gauges

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Dec 26, 2023
README.md Outdated
@@ -1,6 +1,6 @@
# gauges2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the header as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all the build, install and log directories and recompiled following the instructions but I got the following error:

caguero@cold:~/gauges_ws$ ros2 run rqt_gauges rqt_gauges
RosPluginProvider._parse_plugin_xml() plugin file "/home/caguero/gauges_ws/install/rqt_gauges_2/share/rqt_gauges_2/plugin.xml" in package "rqt_gauges_2" not found
RosPluginProvider._parse_plugin_xml() plugin file "/home/caguero/gauges_ws/install/rqt_gauges_2/share/rqt_gauges_2/plugin.xml" in package "rqt_gauges_2" not found
qt_gui_main() found no plugin matching "rqt_gauges.speedometer.Speedometer"
try passing the option "--force-discover"
[ros2run]: Process exited with failure 1

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working passing --force-discover.

@ahcorde ahcorde merged commit 18475ec into main Dec 28, 2023
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rename branch December 28, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants