ENH: CharacterButtonのメニューが常に下方向に展開されるようにする #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabonerune
commented
Apr 18, 2023
| @@ -291,6 +294,18 @@ const reassignSubMenuOpen = debounce((idx: number) => { | |||
| arr[idx] = true; | |||
| subMenuOpenFlags.value = arr; | |||
| }, 100); | |||
|
|
|||
| const buttonRef: Ref<InstanceType<typeof QBtn> | undefined> = ref(); | |||
| const heightLimit = "65vh"; // QMenuのデフォルト値 | |||
There was a problem hiding this comment.
とりあえず元々の動作は変えないようにしました。
参照する方法がなさそうなのでハードコートしました。
Hiroshiba
reviewed
Apr 19, 2023
y-chan
reviewed
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
キャラクター選択メニューが常に下方向に展開されるようにすることで以下の問題を解決します。
関連 Issue
その他
ウインドウサイズを変更したときは可能な限り追従するようになっています。